Security Advisory
Search…
Security Advisory
1.0.0
Security Advisory
1. Insecure Default Secure Boot Policy for Option ROMs
2. Incorrect PKCS#1v1.5 Padding Verification for RSA Signature Check
3. UEFI Variable “Reinstallation”
4. Overwrite from Performance Data Variable
5. CommBuffer SMM Overwrite/Exposure
6. TOCTOU Issue with CommBuffer
7. SMRAM Overwrite in Fault Tolerant Write SMI Handler
8. SMRAM Overwrite in SmmVariableHandler
9. Integer/Heap Overflow in SetVariable
10. Heap Overflow in UpdateVariable
11. Overwrite from FirmwarePerformance Variable
12. Integer/Buffer Overflow in TpmDxe Driver
13. Protection of PhysicalPresence Variable
14. Boot Failure Related to UEFI Variable Usage
15. Buffer Overflows in Capsule Update
16. Boot Failure Related to TPM Measurements
17. Buffer Overflow in Variable Reclaim
18. Overflow in Processing of AuthVarKeyDatabase
19. Counter Based Authenticated Variable Issue
20. Honoring Memory Only Reset Control and correct MOR spec imlementation
21. TCG PP S4 issue
22. BIOS Password
23. OPAL driver has PP issue on BlockSid
24. OPAL driver has PSID issue
25. DHCP misses boundary check for network packet
26. SmmCore comm buffer check has TOCTOU issue
27. UEFI Variable Deletion/Corruption
28. EDK II Untested memory not covered by SMM page protection
29. Unauthenticated Firmware Chain-of-Trust Bypass
30. EDK II Authenticated Variable Bypass
31. EDK II TianoCompress Bounds Checking Issues
32. DNS Packet Size Check
33. Opal BlockSid Setting Disabled after S3
34. PartitionDxe and Udf Buffer Overflow
35. Stack Overflow on Corrupted BMP
36. Buffer Overflow in BlockIo service for RAM disk
37. XHCI stack local stack overflow
38. SW SMI Confused Deputy SmramSaveState.c
39. Unlimited FV Recursion
40. AuthVariable Timestamp Zeroing on APPEND_WRITE
41. BootGuard TOCTOU
Powered By GitBook
25. DHCP misses boundary check for network packet

Description:

The UEFI DHCP Protocol has many conventions for processing and caching incoming DHCP4/DHCP6 packets. Their current exists a check in PxeBcCacheDhcp4Packet before calling CopyMem() on two EFI_DHCP4_PACKET structs. This check uses an ASSERT which will be compiled out for RELEASE builds of UEFI on EDK II.
But actually, the source is from an external network, and there is no guarantee that the source Length is smaller than destination size. It might happen.

Recommendation:

  1. 1.
    For this specific issue, we need remove ASSERT and use error checking.
  2. 2.
    clarify the rule, ASSERT can only be used for something never happen. Error check must be used for something might happen.
This is addressed by EDK2 GIT 4f6b33b460226bc1a54d8af2c0f4fe195f2f04ce, 632dcfd6857b6211ce3fe9755d3c11e74ef5d4477, 471342bbefaac1c21fe7fa4e80949b552b12fbdd, a35dc6499beb0b76c340379a06dff74a8d38095a.

Acknowledgements:

Reported by Timzen, Topher [email protected]​

References:

• USRT M1622
Previous
24. OPAL driver has PSID issue
Next
26. SmmCore comm buffer check has TOCTOU issue
Last modified 1yr ago
Copy link
Contents
Description:
Recommendation:
Acknowledgements:
References: